Skip to content

fix: fix type and mark deprecated as no usage for unused xcodeVersion and deprecated idb#1072

Merged
KazuCocoa merged 3 commits into
masterfrom
type-modify
Nov 29, 2025
Merged

fix: fix type and mark deprecated as no usage for unused xcodeVersion and deprecated idb#1072
KazuCocoa merged 3 commits into
masterfrom
type-modify

Conversation

@KazuCocoa
Copy link
Copy Markdown
Member

@KazuCocoa KazuCocoa commented Nov 28, 2025 •
edited
Loading

Previously, they can be undefined for webDriverAgentUrl / usePreinstalledWDA usage, but it looks like the xcodeVersion can be undefined for WebDriverAgent today. So, we'll be able to drop the first argument completely in the future - when we bump this major version

kazu $ git grep 'xcodeVersion' lib 
lib/webdriveragent.js:   * @param {import('appium-xcode').XcodeVersion | undefined} xcodeVersion
lib/webdriveragent.js:  constructor (xcodeVersion, args, log = null) {
lib/webdriveragent.js:    this.xcodeVersion = xcodeVersion;
lib/webdriveragent.js:    : new XcodeBuild(this.xcodeVersion, this.device, {
lib/xcodebuild.js:   * @param {import('appium-xcode').XcodeVersion | undefined} xcodeVersion
lib/xcodebuild.js:  constructor (xcodeVersion, device, args, log = null) {
lib/xcodebuild.js:    this.xcodeVersion = xcodeVersion;
kazu $

Also, I didn't see this xcodeVersion reference from xcuitest driver.

@KazuCocoa KazuCocoa mentioned this pull request Nov 28, 2025
Merged
@mykola-mokhnach
Copy link
Copy Markdown

mykola-mokhnach commented Nov 28, 2025 •
edited
Loading

Lets also deprecate the idb property (will do in a separate PR) and then remove the deprecated stuff altogether after major version bump

@KazuCocoa KazuCocoa changed the title fix: fix type and mark deprecated as no usage fix: fix type and mark deprecated as no usage for unused xcodeVersion and deprecated idb Nov 29, 2025
@KazuCocoa KazuCocoa merged commit 4499fb2 into master Nov 29, 2025
44 of 48 checks passed
@KazuCocoa KazuCocoa deleted the type-modify branch November 29, 2025 02:54
github-actions Bot pushed a commit that referenced this pull request Nov 29, 2025
@semantic-release-bot
chore(release): 10.2.3 [skip ci]
02a6cc7 
## [10.2.3](v10.2.2...v10.2.3) (2025-11-29)

### Bug Fixes

* fix type and mark deprecated as no usage for unused xcodeVersion and deprecated idb ([#1072](#1072)) ([4499fb2](4499fb2))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 29, 2025

🎉 This PR is included in version 10.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KazuCocoa @mykola-mokhnach